Generate debug port in range for Chrome DevTools websocket - iOS #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petekanev
requested review from
mbektchiev,
ginev,
Mitko-Kerezov and
tdermendjiev
petekanev
force-pushed
the
pete/generate-debug-port-ios
branch
from
a163224 to
09e0025
Compare
petekanev
force-pushed
the
pete/generate-debug-port-ios
branch
from
09e0025 to
b37d93b
Compare
rosen-vladimirov
approved these changes
Dec 18, 2017
test/services/ios-debug-service.ts
Outdated
| @@ -48,6 +49,12 @@ const createTestInjector = (): IInjector => { | |||
| on: (event: string | symbol, listener: Function): any => undefined | |||
| }); | |||
|
|
|||
| testInjector.register("net", { | |||
| getAvailablePortInRange: function (startPort: number, endPort?: number): any { | |||
There was a problem hiding this comment.
You should return Promise here.
And also you can use lambda syntax here:
testInjector.register("net", {
getAvailablePortInRange: async (startPort: number, endPort?: number): Promise<number> => 41000
}
KristianDD
reviewed
Dec 18, 2017
lib/services/ios-debug-service.ts
Outdated
| @@ -212,7 +213,7 @@ export class IOSDebugService extends DebugServiceBase implements IPlatformDebugS | |||
| this.$logger.info("'--chrome' is the default behavior. Use --inspector to debug iOS applications using the Safari Web Inspector."); | |||
| } | |||
|
|
|||
| this._socketProxy = await this.$socketProxyFactory.createWebSocketProxy(this.getSocketFactory(device)); | |||
| this._socketProxy = await this.$net.getAvailablePortInRange(41000); | |||
There was a problem hiding this comment.
This bypasses a lot of logic, please check it.
There was a problem hiding this comment.
Right, must have pushed the wrong thing
petekanev
changed the title
petekanev
force-pushed
the
pete/generate-debug-port-ios
branch
from
b37d93b to
fe1d39d
Compare
petekanev
changed the title
KristianDD
approved these changes
Dec 19, 2017
…evtools When generating a port to start a websocket on, use the same logic as is present in the android debug service - get the first available available port in a range, and reuse it for the next debug session of the same application if it is still available
…addapter Check for available port is done on this adapter and by default server is launched on "::" which is IPv6's any adapter
mbektchiev
force-pushed
the
pete/generate-debug-port-ios
branch
from
08eb7f3 to
a82b4f1
Compare
mbektchiev
approved these changes
Jan 4, 2018
There was a problem hiding this comment.
Let's merge it along with #3281 because they are needed for the latest debugging improvements in ios-runtime
mbektchiev
pushed a commit
that referenced
this pull request
Jan 5, 2018
* fix generating port for debug socket when debugging ios with chrome devtools When generating a port to start a websocket on, use the same logic as is present in the android debug service - get the first available available port in a range, and reuse it for the next debug session of the same application if it is still available * fix(device-socket): iOS Socket proxy should listen on IPv4 localhost adapter Check for available port is done on this adapter and by default server is launched on "::" which is IPv6's any adapter
dtopuzov
pushed a commit
that referenced
this pull request
Jan 10, 2018
* Generate debug port in range for Chrome DevTools websocket - iOS (#3275) * fix generating port for debug socket when debugging ios with chrome devtools When generating a port to start a websocket on, use the same logic as is present in the android debug service - get the first available available port in a range, and reuse it for the next debug session of the same application if it is still available * fix(device-socket): iOS Socket proxy should listen on IPv4 localhost adapter Check for available port is done on this adapter and by default server is launched on "::" which is IPv6's any adapter * Fix debug device/web socket closing (#2897) When we close the websocket we have to destroy the device socket as well. We need to wait the close event on the device socket instead of end. * fix(ios-inspector): Correctly update cached inspector package to latest compatible version (#3302) * Currently it is never updated and is left at the first version ever installed in `~/.local`. As a result newly published inspector packages are not used unless the user installs them explicitly in the project or deletes the cache manually. * The iOS inspector package version must be determined according to project's iOS runtime version instead of the version of CLI as it has been till now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a port to start a websocket on, use the same logic as is present in the android debug service - get the first available available port in a range, and reuse it for the next debug session of the same application if it is still available
Fixes #3183 and #3261